#saltr (irc2p) | I2P+ 2.9.0-23+ >> i2pplus.github.io | skank.i2p | git.skank.i2p | purokishi.i2p | vituperative.github.io/i2pchat | notbob.i2p | ramble.i2p | drop.i2p | shinobi.i2p | wall.i2p | /msg an op for voice

mareki2p Reading docs about streaming. Plain ACKs. "If the sequenceNum is 0 and the SYN flag is not set, this is a plain ACK packet that should not be ACKed." What if I have long lasting stream opened and shoving lots of data thru it. Like for months. Sooner or later sequence number will roll over and one of the packet will never be ACKed. Sender will wait for ACK that never comes. Do I read it right? If you think 4G pa

mareki2p ckets is way too many to ever happen, there was something vaguely similar in the Linux kernel triggered by rsync, or something like that.

dr|z3d I heard you like timestamps, mareki2p :)

dr|z3d We now haz timestamps for log events in the tunnel manager in + :)

mareki2p Yeah, when I see log with ton of messages, each message better have timestamp. Snark does not do it.

dr|z3d correction: canon's snark doesn't do it.

dr|z3d you've got used to +'s snark :)

mareki2p Nice!

dr|z3d I thought you were already aware?

dr|z3d in any event, just post a screenshot of +'s snark screenlogs to your PR, you might find it persuades zzz that timestamps don't actually introduce clutter.

dr|z3d speaking of clutter, the tunnel manager screenlogs have had extensive work done, both to add timestamps to events and reduce clutter / duplicated info. if you're running + dev builds, please test and report any issues. thanks!

mareki2p If I go to the configure web UI of latest snark+ standalone and I paste the value of 4096 into download limit, the UI will refresh and tell me the limit is 4000. WTF?

dr|z3d it's conditional upon whatever bandwidth is configured for the router, and how much it assesses is available. up the share bandwidth in the router.

mareki2p But for upload it works. On the router (Java non-plus) there is also 4096 limit and some percentage such as 90% or 80%.

dr|z3d yeah, there's some limit relative to allocated up/down bw, so you don't totally hose your router by over allocating.

mareki2p How do I specify I2CP username and password in snark+standalone?

mareki2p No, it is something else, it would not connect.

mareki2p net.i2p.client.I2PSessionException: Disconnect Message received: Unsupported crypto type: 6

mareki2p Now it works.

mareki2p Wow I changed I2CP port from 7654 to 8654 where is my other router (i2pd) and I can not change it back.

mareki2p Console output: drop.i2p/paste/ba3cd61cb612410b9c276f250bcd8860

mareki2p So far I'm giving I2PSnark+ standalone negative review, it mostly does not work.

dr|z3d Are you running the latest i2pd from git?

dr|z3d Because if you build snark+ from git, it's expecting support for PQ crypto. in theory it should fall back to ECIES, but maybe that's an i2pd issue in not handling that correctly.

dr|z3d just tested standalone on a pq enabled router, apparently it works fine.

mareki2p I'm running snark+ version from git c354e72b40e2bf9fef68c881be2170f035167ea2 or I2P Java from installer version 2.9.0-0.

mareki2p *and I2P Java non-plus

dr|z3d that'll be why, then, 2.9.0-0 doesn't have pq support.

dr|z3d it should gracefully fallback, but obviously it doesn't.

mareki2p So no backward compatibility and graceful degradation of crypto version?

mareki2p The error from command line console is on drop pastebin.

dr|z3d well, you can either build yourself an update or use a + update file.

mareki2p Yes, it is downloading something.

mareki2p One weird thing is that if I change I2CP port settings, every torrent in torrent list disappers for a while.

mareki2p Until snark reverts the settings back, because it can not connect to vanilla Java.

mareki2p Now it stopped all torrents even if I tried to stop single one.

mareki2p Now it printed error message into web UI when I tried to add trackers to torrent.

mareki2p java.lang.StringIndexOutOfBoundsException: Range [0, -1) out of bounds for length 25

mareki2p Call stack: drop.i2p/paste/332e6a276c214de79e7c036092847495

dr|z3d don't see that issue here. where did you get snark from?

dr|z3d > Open Tracker list changed - torrent restart required to take effect.

dr|z3d and are you prefixing your urls with ?

dr|z3d actually doesn't matter, don't supply it, it'll get automatically added. I've tried both, with and without, work fine.

dr|z3d if you didn't grab the latest snark from skank, that's what you want.

mareki2p I have snark+ from git, version from commit c354e72b40e2bf9fef68c881be2170f035167ea2. I added a BTIH as new torrent, without any URL, just the BTIH. Then, after snark got the .torrent file I stopped it, went to torrent details in the web UI, checkeck all the trackers, selected one pripary and pessed OK.

dr|z3d oh, you're adding a new tracker to the torrent.

dr|z3d I was adding a new tracker in the configs.

mareki2p Now I can not get to the torrent details, the same exception in web UI appers.

dr|z3d let's see if I can reproduce the error here.

mareki2p I try also with different BTIH.

dr|z3d I just added a tracker to a torrent, worked fine.

dr|z3d were you trying to add a udp tracker perchance?

mareki2p All of the default ones, so yes.

mareki2p Yes, reproduced on different torrent.

mareki2p Steps to reproduce. Add some BTIH such as 9D341C8C27A59ABFF2EBFA2C611CD0D53EC82863. The torrent stars. Let it running for a while, until the name is known. Stop. Edit. Check all the checkboxes, one next to each tracker, check postman as primary. Save. Exception.

dr|z3d because that causes the error you referenced. http trackers work fine. ... investigating ...

dr|z3d if you don't select the udp trackers, it'll work fine.

dr|z3d ok, should be fixed. let me push an update to git.

dr|z3d thanks for spotting.

mareki2p Also stopping one torrent stops all of them.

dr|z3d that should have been fixed in the latest builds.

dr|z3d make sure you're running up-to-date javascript with ctrl+shift+r

dr|z3d ok, fix for adding udp trackers to torrents pushed to git. thanks!

mareki2p Adding UDP trackers now work well in newest version from git. But stopping a torrent will stop all of them. Deleting torrent does not work.

dr|z3d OK, thanks, mareki2p, thought that bug was squashed already, will take another look.

dr|z3d delete torrent I can confirm, stopping a single torrent works here.

orignal dr|z3d right

orignal I didn't have a chance to test PQ over I2CP yet

dr|z3d I imagine it'll work fine, orignal

orignal not sure

orignal need to test

dr|z3d mareki2p_ confirms it works with a pq-enabled i2pd

dr|z3d <mareki2p> It seems to work fine against i2pd built from git 10 days ago. But I uploaded nothing so far.

orignal nice

dr|z3d speaking of, I think I've got this non-delete bug fixed, mareki2p_, code to git shortly.

dr|z3d ok, should be fixed and on git, mareki2p

dr|z3d and new + dev build and snark standalone now available on skank with fixes.

mareki2p Yes the new snark standalone + works fine with i2pd built from sources approx 10 days ago. Does not work with Java 2.9.0-0.

mareki2p The bug with stopping single torrent causing to stop all other is sthill there.

orignal because Java 2.9 doesn't supprt PQ?

mareki2p The bug about adding UDP trackers is fixed.

mareki2p Yes, most likely drz3d know this the reason, not me, I know the end effect only, not the cause.

mareki2p wow my english is not englishing

mareki2p Starting single torrent appears to start all of them according the animation, but correctly starts the single one. But the start all button disappears.

mareki2p This is from git version 1cd0788f6c4a7ecc915594414e127b16e0998400 (latest).

mareki2p Bug with deleting torrent not working is still there.

dr|z3d when you hit one of the action buttons, they shouldn't disappear, but they will all be temporarily disabled for a couple of seconds.

mareki2p In other news I am able to download front page of reg.i2p via my little I2CP app. Meaning I can send single packet containing HTTP GET request and then ACK all incomming response packets. For some reasons other domains does not work for me.

dr|z3d cannot reproduce the stop torrent button stopping all torrents here, works fine.

mareki2p I still need to implement proper TCP streaming thingie.

dr|z3d same foe start torrent.

dr|z3d the fading (disabling) of buttons after you hit start or stop or delete or remove is expected and intentional behavior.

dr|z3d there's also a slight lag before the buttons are updated, so it may appear after a click that nothing's happening.. give it a few moments to refresh the UI.

dr|z3d (it's a side effect of not forcing the entire page to reload on form submit)

mareki2p I can reproduce it. I copy & paste the built standalone zip to empty directory. I copy & paste about 40 torrents (I use hard links instead of copy & paste). Start all. Stop single. All gets stopped. I changed the speed limit settings, auto-start torrents, I2CP port number.

mareki2p I'm on Windws Server 2022, Java 24.

dr|z3d can you try clearing your browser cache?

dr|z3d ok, strange, in standalone I can reproduce stop causing stop all, start appears to be fine.

dr|z3d presumably delete works fine now?

dr|z3d or you say it's still not working.. hmm...

dr|z3d zzz: I think we have another illegal character that needs to be escaped in snark files.. "!"

dr|z3d [ and ] are also potentially problematic.

zzz on what platform?

dr|z3d linux

zzz there's only two illegal chars in linux filenames

dr|z3d while that might be technically true, in snark ! and [ and ] apparently cause barfage.

zzz barfage where

dr|z3d info pages.

zzz html issues then?

dr|z3d don't think so: java.net.MalformedURLException: Illegal character in path at index 30 ...

dr|z3d unless you mean the URL parsing, in which case, yes. :)

mareki2p Steps to reproduce. git clean -dfx, git reset --hard --, git pull, ant i2psnark, copy zip archive, extract to epty dir, change port number in jetty-i2psnark.xml, java -Xmx4G -jar i2psnark.jar, hard link bunch of torrents, open anonymous web window, wait for all torrents to appear, change I2CP port to other number in web ui, wait again, start all, stop single ---> all gets stopped, I2CP connection

mareki2p gets closed

zzz so that's a URL issue, not a filename issue, although one turns into the other

dr|z3d sure, can confirm. it appears to be a standalone issue. don't ask me why.

dr|z3d yes, zzz.

dr|z3d we should be able to escape the dubious characters or encode them.

mareki2p Also, if you click torrent details, the URL is name of the torrent. What if I have two torrents with the same name, but different BTHI? Collision? The other's details could not be opened?

zzz [ and ] but not ! are encoded in URIUtil, so either you're not encoding, or the problem is !

dr|z3d There's definitely some encoding going on if you look at what I sent you via OM, but it doesn't appear to be encoding the [ ] in the filename, just spaces. will investigate, thanks.

dr|z3d *PM

mareki2p Also this happens when stopping single one: drop.i2p/paste/31116edcf63d4f2899c2ec016a61e6d0

dr|z3d ok, thanks, mareki2p, will investigate that too, I suspect the issues are loosely related.

dr|z3d I think I found the issue with [ ], zzz. good call. buf.append("<a href=\"").append(torrentPath); <-- not escaping here.

zzz [] are very common in torrent/file names and they seem to be encoded correctly here in canon land

dr|z3d buf.append("<a href=\"").append(DataHelper.escapeHTML(torrentPath)); I think is what I should have.

dr|z3d so that fixes the href, but not the actual page itself, more hunting required.

zzz I used to have a bunch of local torrents I created with a huge array of wild filenames

zzz I used them to stomp out all the issues years ago, but I left it in the snark dir for years and would periodically recheck

zzz only takes a couple minutes

zzz dr|z3d, npte that URI encoding rules are different than HTML encoding rules, and DataHelper.escapeHTML() does not escape []. test test test

snex can we please just grab a new person and make them rewrite the UI in a modern framework

zzz sure, I'll post a job listing today ))

cumlord any reason router.pumpMaxOutboundMsgs setting too high would make leasesets expire

zzz sounds like a cannon invention

cumlord might be lol i wouldn't know

cumlord i started putting outbound priority 25 to prevent certain tunnels from expiring which works but then if you do too many at 25 then they still expire

dr|z3d shit's flying thick today.

dr|z3d :)

dr|z3d test test test, ack, zzz.

zzz I thought outbound priority was only for data messages, but maybe not, don't recall

zzz build msgs should have their own priority, and between tunnel pools, there's some other prioritization

dr|z3d cumlord: re pumps, dunno, seems unlikely, but worth investigating. I'll have a look.

dr|z3d in theory whatever we're pumping, our own stuff takes precedence over everything else.

cumlord noticed the outbound priority thing because i had priority on 25 for irc tunnel, and that one never expired while the other ones did. not sure of the mechanics

cumlord i was upping pumpMaxOutboundMsgs to 512-1024 to see if i could squeeze some more out, seemed like it did while increasing message delay, but also started expiring leasesets

cumlord could be unrelated seems like anytime speed goes too high the leasesets get tired

zzz we try pretty hard to prevent that, but perhaps with enough configuring you could sabotage it, or perhaps some cannon changes are detrimental. no idea.

dr|z3d private static final int MAX_OB_MSGS_PER_PUMP = 64;

dr|z3d private static final int MAX_IB_MSGS_PER_PUMP = 24;

dr|z3d private static final int INITIAL_OB_QUEUE = 64;

dr|z3d private static final int MAX_IB_QUEUE = 1024;

dr|z3d */

dr|z3d private static final int MAX_OB_MSGS_PER_PUMP = SystemVersion.isSlow() ? 256 : 1024;

dr|z3d private static final int MAX_IB_MSGS_PER_PUMP = SystemVersion.isSlow() ? 128 : 512;

dr|z3d private static final int INITIAL_OB_QUEUE = SystemVersion.isSlow() ? 128 : 512;

dr|z3d private static final int MAX_IB_QUEUE = SystemVersion.isSlow() ? 1024 : 4096;

dr|z3d top is canon, bottom is cannon, if that's not obvious.

dr|z3d don't taze me, bro!

dr|z3d *** grins. ***

zzz the generic answer to 'if I set adv config X too high could it have bad side effects' is yes, for all X

cumlord put those 4 settings to what canon had, it liked that

cumlord at least with 2MB traffic anyway, i'll push it later and see what it does

dr|z3d *thumbs up*