#saltr (irc2p) | I2P+ 2.5.2+ >> i2pplus.github.io | skank.i2p | git.skank.i2p | purokishi.i2p | vituperative.github.io/i2pchat | natter.i2p | notbob.i2p | ramble.i2p | shreddit.i2p | cake.i2p | /msg an op for voice

T3s|4 zzz and dr|z3d - I was able to reproduce my all new torrents remain stalled issue, along with a fix on my end. Hope this information is helpful in your investigation, see: paste.rs/cS48R

dr|z3d thanks, T3s|4, maybe that'll help zzz troubleshoot. in future, when you say 15K download speed and you mean 15,000K download speed...

zzz dr|z3d, this is your product, please try to reproduce

zzz have you double checked your merge yet?

zzz oh this is megabytes. 28000KBps = 28 MBps = 224 Mbps

zzz smells like an integer overflow somewhere

zzz T3s|4, please give me the three SREDQ lines from the debug bandwidth limiter section on /i2psnark/?p=2

zzz dr|z3d, I can't set more than 9999 on the form, I have maxlength=4, so I can't reproduce, this is your mod and your problem until you can reproduce it on canon

dr|z3d probably just needs form input validation in that case, I see why I never encountered the issue, I've got my value set to 9999. you can repoduce if you edit i2psnark.config directly.

zzz I could but I'm not

dr|z3d that's fine, but "cannot reproduce" isn't entirely accurate :)

dr|z3d it's a corner case at best, but there may be users that edit the config file rather than use the UI to set values.

zzz if you're trying to convince me to fix your problem it's not going to work

dr|z3d I can fix the issue superficially, no need for help there, but my "problem" is a symptom, not the cause.

T3s|4 zzz: assuming you meant the output of: 127.0.0.1:7667/i2psnark/?p=2, these are the final 3 lines, see: paste.rs/RsbA9

dr|z3d cake.i2p/pastebin T3s|4 :)

zzz thanks, unfortunately that's different than what's in my code, but perhaps it's useful to drz

T3s|4 dr|z3d: not sure what you are asking; in the US, 15K always means 15,000, never 15,000K. Per my earlier paste, re: 127.0.0.1:7667/i2psnark/configure: 15K = 15,000 K/B/s down under 'Bandwidth limit' = 15,000 - and not some other number

dr|z3d 15K down is not the same as 15,000K down. 15K does not equal 15000KB when referring to KiloBytes.

dr|z3d I was referring to your original report here, not the pastebin.

dr|z3d >> I forget what the original snark default d/l value was, but probably over 30K. In my testing, 1K, 2K, 5K and 15K all work - with no stalls. It's taken me days to pin this down

T3s|4 OK, those all refer to 1,000, 2,000, 5,000 and 15,000 all being physically entered into the Bandwidth limit K/B/s field within: 127.0.0.1:7667/i2psnark/configure - Torrent Options section, then saving and/or i2p router restart

dr|z3d well, you understand the confusion. when you say 15K, we can't know whether you mean 15,000KB or 15KB.

dr|z3d anyways, thanks for reporting. I'll add a form validation check and make sure that there's a max value set that doesn't break things.

T3s|4 and I do means ONLY entering values such as 15,000 into Bandwidth limit XXX K/B/s down field, afaict, up rates/limits afaict are wildly unrelated

T3s|4 *do mean

dr|z3d did you identify roughly where things go tits up, value-wise?

T3s|4 well, you understand the confusion - no, I do not understand it. I thought I was abundantly clear about where and which numerical values I entered

dr|z3d let's move on. in future, don't abbreviate when you're stating specific values entered into a field :) 15000 is 15000.

dr|z3d I'm asking what the threshold was that caused the stalls? 15000, more, less?

zzz he answered that in 1st paste

dr|z3d yeah, I know. I was just saying his original in-channel report was confusing, at least to me if no one else.

dr|z3d about 90% done with svg identicons.

dr|z3d drawing them natively, not leveraging jfreesvg.

T3s|4 dr|z3d: was slammed for time between meeting earlier, unit values now corrected for i2p KBps vs snark KB/s semantic consistency, no numeric changes - and your success threshold query was addressed in my original post, see: paste.rs/b9Yxp

T3s|4 still not sure how a misinterpretation occurred, despite minor unit value misstatements, given the provided i2p and snark source URLs

dr|z3d let's put this to bed, shall we? initial comment in channel of 1K, 5K etc was confusing. subsequent pastebins cleared up the issue.

dr|z3d re the absolute limit, if you're saying 15000 KB/s is the absolute max you can configure before stall, then we might as well just set it to 9999K and be done with it.

T3s|4 dr|z3d: 15,000 KB/s is the highest Bandwidth limit down success level I've tested - in no way am I suggesting it's the upper limit. As I pasted, neither 28,000 or 25,000 KB/s down work for me

dr|z3d ok, I was asking if you'd discovered an upper limit. but I guess that's not so important, we'll just limit to 9999K which seems you're unlikely to ever reach in the next 5 years and all should be good.

T3s|4 now I am not following your math: how do 15,000 KB/s down and 9999K relate?

dr|z3d 4 digits.

dr|z3d effectively the same as vanilla.

T3s|4 meaning a limit of 9,999 KB/s down as a maximum down rate value?

dr|z3d correct.

dr|z3d can be validated, but just an importantly, with 4 digits you're not going to exceed what we know to be functional limits, so it's easy to implement at the ui level. can't type more than 4 digits and you don't need any additional guidance.

T3s|4 why is the value changeable if it has little to no impact, except when set 'too high' causing torrent stalls?

dr|z3d it has effect at the low end, when you don't want all your bandwidth being consumed downloading a well seeded torrent.

T3s|4 and I do mean only the snark 'down' rate value

T3s|4 dr|z3d: ^noted

dr|z3d what zzz referred to previously as the "firehose effect".

T3s|4 not sure whether this snark maximum KB/s 'down' rate value was ever a bug, or just an oversight, but iirc, under a clean install of + with 50,000 KBps in/out set, 80% share, ~28,000 KB/s down was the default preset within snark, causing the new torrent stalls. Could only be possibly replicated with a new OS/VM, but no time or interest in that path

dr|z3d I'm fairly confident 28000KB/s isn't the default, but I'll take some time to review the code when I implement the fix.

T3s|4 Is the snark 'down' KB/s rate only 'user set' or is calculated based on on the user's values set in 127.0.0.1:7667/config?

dr|z3d I'd have to review the code. I don't recall.

T3s|4 np - lmk, that might be the crux of this

T3s|4 ofc, those with lower ISP connection speeds would likely never have encountered the stalling issue; but I suspect there are others with superior ISP speeds