IRCaBot 2.1.0
GPLv3 © acetone, 2021-2022
#i2p-dev
/2023/11/02
eyedeekay Regarding the DC, a lot of what we already knew(we need a new server) but there's a chance I can get my hands on the hardware itself
eyedeekay Turns out it wasn't my fault the server broke either, according to the DC it was a drive failure
eyedeekay Not that it really matters
eyedeekay Also, meeh's still alive
RN eyedeekay, so does your test2 differ much from what's in master now?
eyedeekay Oh it's behind master. Edited the post again to reflect that current is on master
zzz eyedeekay, I was really confused by your questions on MR 143 but I replied as best I could
zzz if you wish to move the discussion here that might be faster. I think this MR is blocking to a lot of other work to be done
eyedeekay I think you answered tHe
eyedeekay important ones 1 and 4, you clarified what I was trying to get a handle on
zzz ok good
zzz any other questions?
zzz and heads up, I'm not sure I can meet your new big changes deadline in 4 days
zzz ^^ eyedeekay
eyedeekay No other Q's, pushed the date back an additional week, let me know if you need more time
zzz eyedeekay, ok, for my planning, what's your ETA for approving MR 143?
eyedeekay Consider it approved as of this conversation
zzz ok, so may I merge it, and bump the rev?
eyedeekay Go right ahead
zzz great, thank you very much
eyedeekay You're welcome
zzz where in the code will you be next couple of days?
eyedeekay I'm going to try and nail down the rest of the lookup throttle stuff next
zzz I still think we can get rid of the burst throttler. Are you leaning that way or not?
eyedeekay I also am
zzz I'm working on another big change to revert DummyNDF and netdb() return type
zzz so that will be next from me I think?
eyedeekay Sounds good, I can stay out of your way then
eyedeekay After the lookup throttler I am going to fix some website stuff
zzz what are your thoughts on wholesale reverting the banlist changes? I don't think you've weighed in
eyedeekay I am reasonably convinced of your concerns with the code, and open to reverting it. But obscuratus and I did agree that something weird was affecting the banlists causing them to grow to alarming sizes, which we thought may have been an attacker trying to make bans less effective/nonsensical or to DOS the network by causing routers to ban eachother.
eyedeekay This is probably another place where we got into the weeds and reverting is probably good
zzz well, the question then is, do the changes fix the "weird" banlist growth, or are they unrelated?
eyedeekay But I would like to take another run at the issues that motivated the changes if they emerge again after the release
zzz is there a clear goal -> implementation here?
eyedeekay That's why I am on board with reverting, I am no longer convinced they work
zzz or is it just thrashing in the general vicinity?
eyedeekay closer to the latter, revert is the right thing to do,
zzz I'm not looking at the discussion right now, but iirc obscuratus didn't effectively defend the changes
eyedeekay No and I don't think I questioned them adequately before merging them
eyedeekay possibly failed to make the distinction between 'understanding what's going on code' and 'fixing stuff code' also
zzz yeah and imho the former shouldn't be in trunk
zzz lets not have our codebase look like we don't understand it
zzz ok my MR for Dummy stuff will be about 500 lines, will be testing today and hope to get it up tomorrow
RN If you want to test the dev version but don't want to build it youreself you can grab an updater file at I2Peek-a-Boo.i2p 2.3.0-10
dr|z3d <3 git :)