eyedeekay
And off it goes
obscuratus
It's been a minute since I updated master.
obscuratus
If a router is *NOT* a FloodFill, is there any reason to handle a DLM for anything but their own RI?
obscuratus
Maybe it's healthy for the network as a fall-back? Or maybe just drop those early.
obscuratus
Of course, with a segmented netDb, it should be a moot point.
dr|z3d
obscuratus: I now drop lookup requests from other routers for anything other than our own RI if we're not a ff.
obscuratus
Thanks dr|z3d
dr|z3d
here's the code:
dr|z3d
} else if (!_context.netDb().floodfillEnabled() && !_facade.shouldBanLookup(dlm.getFrom(), dlm.getReplyTunnel())) {
dr|z3d
if (_log.shouldInfo()) {
dr|z3d
_log.warn("Dropping " + searchType + " lookup from [" + dlm.getFrom().toBase64().substring(0,6) + "] " +
dr|z3d
"for [" + dlm.getSearchKey().toBase64().substring(0,6) + "] -> " +
dr|z3d
"We are not a floodfill [TunnelId " + dlm.getReplyTunnel() + "]");
dr|z3d
} else if (_log.shouldWarn()) {
dr|z3d
_log.warn("Dropping " + searchType + " lookup from [" + dlm.getFrom().toBase64().substring(0,6) + "] " +
dr|z3d
"for [" + dlm.getSearchKey().toBase64().substring(0,6) + "] -> We are not a floodfill");
dr|z3d
}
dr|z3d
one sec, I'll get you a link for the entire context/file.
dr|z3d
git.skank.i2p/i2pplus/I2P.Plus/src/commit/46f542914f229c7a353cb2cfee093f96ac6173b3/router/java/src/net/i2p/router/networkdb/kademlia/FloodfillDatabaseLookupMessageHandler.java#L71
obscuratus
OK, I was confused. Canon is also dropping DLM when we're not a FF, unless for our own RI.
dr|z3d
sounds about right, obscuratus, I think eyedeekay followed my lead on that iirc.
obscuratus
Haha! This is embarassing. I'm the one who changed that.
dr|z3d
!