@eyedeekay
&eche|on
&kytv
&zzz
+R4SAS
+RN
+RN_
+T3s|4
+acetone
+dr|z3d
+hk
+orignal
+postman
+weko
+wodencafe
An0nm0n
Arch
Danny
DeltaOreo
FreefallHeavens
Irc2PGuest21357
Irc2PGuest21881
Irc2PGuest32033
Leopold_
Nausicaa
Onn4l7h
Onn4|7h
Over1
Sisyphus
Sleepy
Soni
T3s|4_
aargh2
anon2
b3t4f4c3
bak83
boonst
cancername
cumlord
dr4wd3
eyedeekay_bnc
hagen_
khb
not_bob_afk
plap
poriori
profetikla
r3med1tz-
rapidash
shiver_
solidx66
tr
u5657
uop23ip
w8rabbit
x74a6
not_bob
zzz: Thank you for fixing the OOM issue and adding a delay in loading torrents with i2psnark!
zzz
sure not_bob_afk nothing like an OOM to ruin your day
dr|z3d
zzz: git.idk.i2p/i2p-hackers/i2p.i2p/-/blob/master/router/java/src/net/i2p/router/peermanager/DBHistory.java#L44
dr|z3d
probably wants to be 60*60*100l
zzz
whataboutit?
dr|z3d
probably wants to be 60*60*100l
zzz
why?
dr|z3d
because you changed the stat frequency in ProfileOrganizer?
dr|z3d
java.lang.NullPointerException: Cannot invoke "net.i2p.stat.Rate.getCurrentTotalValue()" because "invalidReplyRate" is null
zzz
I didnt touch it
zzz
ProfileOrganizer.java: Rate invalidReplyRate = invalidReplyRateStat.getRate(30*60*1000l);
dr|z3d
ok, my bad, guess your rejigging of the values unturfed something I'd changed, like that rate.
zzz
all I did in that commit was move some code around
dr|z3d
yeah, not that commit, possibly the one where you junked a bunch of 30m stats.
dr|z3d_
yeah, nevermind then. maybe git.idk.i2p/i2p-hackers/i2p.i2p/-/commit/37beb532454b010eae904c5aca26848d8717c241 did some stuff that indirectly poked at some changes I'd made here.
dr|z3d_
(I removed most of the 30m stats a while back)
zzz
ok
dr|z3d_
I see it now.
dr|z3d_
you removed createRates(statGroup);
dr|z3d_
and added: _invalidReplyRate = new RateStat("dbHistory.invalidReplyRate", "How often does this peer give us a bad (nonexistant, forged, etc) peer?", statGroup, new long[] { 30*60*1000l });
dr|z3d_
whereas I'd set that at 60m previously. so no worries.
zzz
didnt add it, just moved it
dr|z3d
sure, and I missed the change in rate in the merge.
dr|z3d
you might disagree, but having a base value of 60s for all graphable stats gives you a common scale for the graphs.
zzz
it does, but at a memory/cpu cost
dr|z3d
always some tradeoff, but I haven't noticed much in the way of an unreasonable demand on either here, and most of the stats are @ 1m.