@eyedeekay
&zzz
+R4SAS
+RN
+RN_
+StormyCloud
+acetone
+dr|z3d
+eche|off
+orignal
+postman
+qend-irc2p
+snex
+wodencafe
Arch
BubbRubb
Chrono2
Danny
DeltaOreo
FreefallHeavens
Irc2PGuest14886
Irc2PGuest30741
Irc2PGuest51880
Irc2PGuest82658
Irc2PGuest89246
Onn4l7h
Sisyphus
Sleepy
SlippyJoe
T3s|4_
Teeed
aargh2
ac9f
b3t4f4c3___
bak83
coolbuddy799
dr4wd3
duanin2
duck
leopold
makoto
mareki2p
nilbog-
not_bob_afk
poriori
profetik1
r00tobo_BNC
rapidash
shiver_1
solidx66
thetia
u5657
uop23ip
vivid_reader56
w8rabbit
x74a6
zzz
dr|z3d, re: deadlock, did the deadlock detector catch it? the logs you gave me were from a thread dump
dr|z3d
no, don't think so, didn't see that in the logs, anyways.
zzz
hmm.
dr|z3d
I might have missed it, however.
zzz
just curious.
zzz
anyway, I'm testing a fix now
dr|z3d
it should appear as a critical entry, no?
dr|z3d
the deadlock detection?
zzz
yup
dr|z3d
probably never had chance, then. router just froze outright.
zzz
might be the ReadWriteLock thing, or maybe it didn't get around to it. Detector only runs every 24 hours by default but you may wish to change it to 1 hour if you haven't
zzz
seems to be pretty quick anyway, maybe I'll reduce the default
dr|z3d
sure, can do, what knob do I tweak for that?
zzz
private static final String PROP_INTERVAL = "router.deadlockDetectIntervalHours";
zzz
private static final long DEFAULT_INTERVAL = 24;
dr|z3d
thanks
dr|z3d
what are you thinking, defaulting to every hour?
zzz
dunno, I'll put it on my list
dr|z3d
defaulting to every hour now in i2p+
dr|z3d
what might be worth considering is automatically restarting the router if a deadlock is detected, after writing out the deadlock to a timestamped file, separate from logs.
zzz
I added it to the event log yesterday
dr|z3d
noticed that.
zzz
yeah might be worth a restart
zzz
although that would make it harder for people to notice and report
zzz
maybe just splat something out in the sidebar
dr|z3d
well, if you write out a stacktrace and whatever else required to a separate file, you can check for that on startup and then splat something in the sidebar if it's present, then delete on next restart?
dr|z3d
that would serve a few purposes.. firstly, you get exactly what you need when it's submitted, not a bunch of guff from the logs, and delete on subsequent restart means you keep the file count low so those reports don't stack up.
zzz
the proposal is getting messy.... maybe we just count on you to find all the deadlocks and thats enough? :)
dr|z3d
you could then link to the report in the sidebar so it's a trivial copy and paste job.
dr|z3d
haha, funny :)
dr|z3d
do I get a prizr?
dr|z3d
*prize
zzz
RN used to be the one that found all the bugs first but seems like you're wearing the hat now
eyedeekay
Android Studio updates on Linux are the freakin' worst, sorry about how long this is taking, I'm going to try and be done with at least direct downloads and our F-Droid by tonight
zzz
sure, but you should really update your tools in advance as part of the dev and test process
zzz
don't update your tooling on release day
zzz
take a few more days and make sure everything's right
eyedeekay
Yeah I shouldn't have clicked the yes button when it asked, paying for it
zzz
no, you should have, you just should have done it last week