IRCaBot 2.1.0
GPLv3 © acetone, 2021-2022
#saltr
/2024/05/24
~dr|z3d
@RN
@StormyCloud
@T3s|4
@T3s|4_
@orignal
@postman
@zzz
%Liorar
%RTP
%cumlord
%snex
+BeepyBee
+FreefallHeavens
+Onn4l7h
+Onn4|7h
+Over
+profetikla
+qend-irc2p
+r00tobo_BNC
Arch
BubbRubb
Danny
DeltaOreo
H20
Irc2PGuest21940
Irc2PGuest32330
Irc2PGuest54742
Irc2PGuest74254
Irc2PGuest8260
Irc2PGuest97317
Meow
Stormycloud_
ac9f
acetone_
anontor
floatyfloatilla
fus3r1
halloy13412
mahlay
makoto
mareki2p_
nZDoYBkF
nilbog
noidea
ntty
null911
poriori_
r00tobo[2]
shaye
shiver_1
simprelay
thetia
u5657_
vivid_reader56
zer0bitz
dr|z3d does this look saner, or am I making the same mistake here?
dr|z3d b32 = reader.readLine();
dr|z3d if (b32 == null) {return;}
zzz same
dr|z3d yeah, figured.
dr|z3d so, totally pointless then, as you say. this should cover it: while((b32 = reader.readLine()) != null) {
dr|z3d well, not totally pointless, as it prevents the issue from triggering, but not the correct fix.
dr|z3d what about checking the filesize instead?
dr|z3d int fileLength = (int) file.length();
dr|z3d if (fileLength == 0) {return;}
zzz better
zzz but the reason for a ticket was that this is low priority, not for today, so if you want my analysis you'll have to sit tight ))
dr|z3d sure, I don't think it's something that'll affect most people.
dr|z3d if there's no file at all, non-issue. only zero length file, or presumably a file containing no b32s.
dr|z3d got a stacktrace zzz, bug report updated.