@orignal
@postman
%Liorar
+Onn4l7h
+Over
+marek22k
+nyaa2pguy
+poriori
+profetikla
+qend-irc2p
+r00tobo
+uop23ip
Irc2PGuest30010
RN_
T3s|4
Teeed
acetone_
dr|z3d
f00b4r_
leopold
makoto
nZDoYBkF
noidea
not_bob_afk2
o3d3_
r00tobo[2]
solidx66
dr|z3d
does this look saner, or am I making the same mistake here?
dr|z3d
b32 = reader.readLine();
dr|z3d
if (b32 == null) {return;}
zzz
same
dr|z3d
yeah, figured.
dr|z3d
so, totally pointless then, as you say. this should cover it: while((b32 = reader.readLine()) != null) {
dr|z3d
well, not totally pointless, as it prevents the issue from triggering, but not the correct fix.
dr|z3d
what about checking the filesize instead?
dr|z3d
int fileLength = (int) file.length();
dr|z3d
if (fileLength == 0) {return;}
zzz
better
zzz
but the reason for a ticket was that this is low priority, not for today, so if you want my analysis you'll have to sit tight ))
dr|z3d
sure, I don't think it's something that'll affect most people.
dr|z3d
if there's no file at all, non-issue. only zero length file, or presumably a file containing no b32s.
dr|z3d
got a stacktrace zzz, bug report updated.