IRCaBot 2.1.0
GPLv3 © acetone, 2021-2022
#saltr
/2024/05/24
@RN
@RN_
@StormyCloud
@orignal
@postman
@zzz
%Liorar
%acetone
%cumlord
+BeepyBee
+FreefallHeavens
+Onn4l7h
+Sh0ck
+bak83_
+leopold
+r00tobo_BNC
+uop23ip
+xHarr
Arch
BubbRubb
Danny
DeltaOreo
Irc2PGuest16752
Irc2PGuest33667
Irc2PGuest97218
Maylay
Meow
ac9f_
anontor
b4dab00m
duck
halloy13412
john231
makoto
nZDoYBkF
nilbog-
not_bob_afk
ntty_
poriori_
profetik1
r00tobo[2]
shiver_
simprelay
solidx66
thetia
u5657
vivid_reader56
zer0bitz
dr|z3d does this look saner, or am I making the same mistake here?
dr|z3d b32 = reader.readLine();
dr|z3d if (b32 == null) {return;}
zzz same
dr|z3d yeah, figured.
dr|z3d so, totally pointless then, as you say. this should cover it: while((b32 = reader.readLine()) != null) {
dr|z3d well, not totally pointless, as it prevents the issue from triggering, but not the correct fix.
dr|z3d what about checking the filesize instead?
dr|z3d int fileLength = (int) file.length();
dr|z3d if (fileLength == 0) {return;}
zzz better
zzz but the reason for a ticket was that this is low priority, not for today, so if you want my analysis you'll have to sit tight ))
dr|z3d sure, I don't think it's something that'll affect most people.
dr|z3d if there's no file at all, non-issue. only zero length file, or presumably a file containing no b32s.
dr|z3d got a stacktrace zzz, bug report updated.