IRCaBot 2.1.0
GPLv3 © acetone, 2021-2022
#saltr
/2024/05/24
~dr|z3d
@T3s|4
@eyedeekay
@orignal
@postman
@zzz
%Liorar
+BeepyBee
+Onn4l7h
+Over
+f00b4r
+leopold
+marek22k
+nyaa2pguy
+poriori
+profetikla
+qend-irc2p
+r00tobo
+uop23ip
Arch
Danny
Irc2PGuest30010
Irc2PGuest51117
Irc2PGuest65656
Irc2PGuest74235
MatrixBot
Meow
T3s|4_
Teeed
acetone_
ahiru
anontor
cims
mahlay
makoto
n2_
nZDoYBkF
nilbog
noidea
not_bob_afk
o3d3_
r00tobo[2]
solidx66
stormycloud[m]
user_
dr|z3d does this look saner, or am I making the same mistake here?
dr|z3d b32 = reader.readLine();
dr|z3d if (b32 == null) {return;}
zzz same
dr|z3d yeah, figured.
dr|z3d so, totally pointless then, as you say. this should cover it: while((b32 = reader.readLine()) != null) {
dr|z3d well, not totally pointless, as it prevents the issue from triggering, but not the correct fix.
dr|z3d what about checking the filesize instead?
dr|z3d int fileLength = (int) file.length();
dr|z3d if (fileLength == 0) {return;}
zzz better
zzz but the reason for a ticket was that this is low priority, not for today, so if you want my analysis you'll have to sit tight ))
dr|z3d sure, I don't think it's something that'll affect most people.
dr|z3d if there's no file at all, non-issue. only zero length file, or presumably a file containing no b32s.
dr|z3d got a stacktrace zzz, bug report updated.