#i2p-dev (irc2p) | 2.12.0-8 | https://i2p.github.io/i2p.i2p/i2pupdate.zip | #translators for Weblate translation help

zzz eyedeekay, did you send out that reseed email last week?

zzz also, which rev is the fix? I see two 5/11 revs labeled fix: but neither appears to be a fix

eyedeekay I did send out the reseed email and the tagged version is: 761bd9f26196b1bd81ab7d02c6af3a96088a9600 but the fix was added in 1aa4f4dcbb63d02130f046873ca2cb965c853898

zzz ok. was asking because I haven't heard back from the new guy that he's updated

zzz where's the actual fix in that rev? it's 600 lines changed

zzz seems like a lot of unrelated stuff making it hard to see

zzz looks like service.go line 226?

zzz all the "proxied middleware" and dependency update stuff is unrelated?

eyedeekay 2 places: 1 top of the rebuild function, 2 lines, rs.rebuildMux.Lock() and defer rs.rebuildMux.Unlock() and the other is the seedsProducer/secureRand part you're highilighting

eyedeekay Yes it is

eyedeekay The rest is tightening up rate-limiter config, updating dependencies, and then a few checkins later I walk back some go-i2p integrations I was working on before I cut the release

zzz ok, it's your project, but suggest you stick to one topic per checkin. you love throwing 2 or 3 unrelated things in one commit like commits cost money or something

zzz this is open source, code like people are watching, it makes for an incomprehensible history and isn't good

eyedeekay OK, my bad I think I was rushing things, will keep working on my habits

zzz and mainly for your benefit 5 years from now when you're going back to figure something out

zzz thanks

dr|z3d_ > zzz makes a good point. committing changes per scope also allows you to easily revert changes without having to disentangle commits first.

eyedeekay Yup. I generally think that zzz is almost always right, take his advice very seriously :)

dr|z3d :)

dr|z3d one thing ai is very good at is determining the scope of workspace changes and creating commit messages.

dr|z3d that's technically 2 things, but you get the point :)

eyedeekay "technically 2 things" that's exactly the problem with my checkins :P

dr|z3d *** smiles. ***

eyedeekay Speaking of advice since you're both here, SC has been working on a new router console and trying to discover what we need from i2pcontrol that it does not yet provide, so we're using the i2p.plugins.i2pcontrol plugin to prototype the new methods: github.com/i2p/i2p.plugins.i2pcontrol/pull/6

snex rule 1 - 1 commit per feature. rule 2 - no commit should ever break the build

eyedeekay Not ready yet but we're using it to plan our proposal if you want to pre-view it

dr|z3d so what's the plan? api changes and a new front end?

dr|z3d also, SC working on this? Who is Nick2k4L?

eyedeekay Nick's a SC employee

eyedeekay Yeah that's the idea, we're working on a "Universal" router console which can attach to anything that implements I2PControl, obviously the most important thing it could need is tunnel control

dr|z3d so essentially an itoopie replacement gui then?

eyedeekay But we also found a few places where we wanted access to a little more peer information so that we could also do netDb search and things like that

eyedeekay Yes essentially

dr|z3d as long as the api enforces authentication before you can do anything with it, it's an open book.

eyedeekay Well it's i2pcontrol there's a default password and it's up to the user to change it(in I2P and i2pd anyway, it's different in go-i2p but only if you use the TUI, don't know what you're doing in + at the moment)

dr|z3d no change here afaict. still a default password.

eyedeekay I debated doing it but since go-i2p needs i2pcontrol to be enabled to have a console, it sets a random password then the TUI reads the password out of the config file

eyedeekay That's specifically because go-i2p needs i2pcontrol to have a console though. Which come to think of it is the reason we're working on the proposal

eyedeekay So it doesn't really apply to the Java distros where it can be off by default

eyedeekay the technique go-i2p is using, that is

dr|z3d for enhanced security, forcing the user to set a password on first run would be the way to go, but it's probably low priority.

eyedeekay Yeah not top of the list right now but almost certainly a future feature

zzz StormyCloud has hired somebody? that's news

dr|z3d knowing StormyCloud, he probably recruited him on fiverr :)

eyedeekay No we had a whole process. I interviewed him and everything. There were resumes

zzz eyedeekay, StormyCloud, enhancements to the i2pcontrol API will require a formal proposal

zzz if he's working on i2p why isn't he here?

eyedeekay Yup that's expressly the plan

StormyCloud Because people on irc is grumpy

StormyCloud are*

zzz that's not "expressly the plan" in the PR

eyedeekay The PR is on the plugin, not on i2p.i2p, this is just so we know what to put in the proposal and so I have something to review

zzz the plugin is obsolete, it was pulled into i2p.i2p years ago

eyedeekay I know, that's why we used it for the prototyping, so we could add methods without implementing them in the router in case the whole thing turned into misadventure

zzz around here we start with specs then do code, not vice versa

zzz *** emboldened since I'm "almost always right" )) ***

dr|z3d LOL

eyedeekay Well then specs you shall have, and I'll not bother you with our code until after we have distilled a clear proposal from it

zzz surprised to hear about somebody hired and toiling away for a month and a half without a peep here, but y'all do your thing

zzz #6 nacked

eyedeekay Pretty much expected that at this stage, thanks for the advice

zzz credit to dr|z3d for prying out the secret dev info ))

dr|z3d *** wields his pliers ***

zzz eyedeekay, StormyCloud, this isn't about being a stickler for process, the i2pcontrol API is supported by i2pd, it is not solely a "Java API" as stated in the PR, so it needs their review

zzz and feel free to bother me (and others), the smart way to do proposals is to socialize them and build consensus along the way, not drop some huge proposal out of nowhere

snex dont be a triviot. come win some monero at movie #trivia when the hour ticks

eyedeekay zzz yeah it's no problem we understand that, for us the process is a dependency since we can't achieve the "console that works for everybody" goal without i2pd buy-in

eyedeekay Hopefully that gives you an idea of what we're working on though for when we come back better prepared

zzz sure, exciting news of a new project and new dev

scottpedia zzz: please allow me to express my frustration over the latest i2p where tunnel number setting is removed from the "settings" page and transfered to the individual client tunnel pages.

scottpedia plus not giving the option to set more than 3 tunnels on the web interface

zzz huh?

scottpedia (in the past I could set it to 16)

zzz we haven't changed anything about that

scottpedia okay is that a misunderstanding?

zzz but you do need routerconsole.advanced=true setting, perhaps you removed it or it's a different router?

scottpedia ohh okay that could be an issue. I am using a brand new installation.

scottpedia thanks for the head-up

zzz eyedeekay, one other thing re: i2pcontrol

jpk68 Just in case anyone is interested in a sort of status update, my main integration PR for SAM support is now up on GitHub. It's just awaiting some reviews/suggestions.

jpk68 Thank you all for the help and support so far, I greatly appreciate it :)

zzz link pls jpk68

jpk68 github.com/monero-project/monero/pull/10523

jpk68 It's still marked as 'draft' because some issues need to be resolved still; it can't actually connect to the network yet (almost)

zzz well, if it doesn't work yet, it's awating more than just reviews ((

jpk68 Sorry, my last message had horrible grammar ;)

jpk68 zzz: Fair point, but part of getting there involves some open questions that have yet to be resolved. Just letting you know

jpk68 This is, for the most part, on the Monero side of things, however any review comments would be great (as always)

zzz looks like that comment last week from eyedeekay was very constructive

jpk68 It genuinely was, yes

jpk68 I believe much of that has already been addressed

jpk68 I mean that the comment was addressed with code changes, rather

zzz do you at least have it working locally, with some preliminary resolution of the 'open questions' ?

jpk68 I should probably clarify what I mean by "almost working". The code (which is a ~1100-line change) compiles perfectly fine with no warnings or errors, and the command-line flag to enable SAM connections works fine as well. The SAM session is successfully established with the router, as well

zzz how about talking to peers?

jpk68 Yeah, the errors are mostly with actually connecting to peers/accepting the streams, where on the I2P side of things, it looks like it will usually fail with "LeaseSet not found" and then the daemon's internal network machinery fails with "handshake error"

jpk68 By 'daemon' I mean monerod

jpk68 Sorry if I missed something; got disconnected for a second

zzz suggest you make some local guesses and get it all working, that way you'll find all the problems before idk does

jpk68 For sure, I have been trying for a while :)

zzz you would have found the control socket problem that way

jpk68 Here are some logs of the SAM messages, if you're interested. Don't worry, this just a throwaway key

jpk68 paste.debian.net/plainh/3a59e208

jpk68 *this is

zzz if you're stuck you may wish to play with bitcoin or qbittorrent and do some logging to see a working p2p example

jpk68 I have done much of that, believe me. Been at this for three weeks now :)

zzz couple things

zzz SIGNATURE_TYPE=7 has to be in the DEST GENARATE command, NOT the SESSION CREATE command

zzz next thing

zzz some of the peer destinations end in AAAA which are DSA-SHA1 destinations, not sure if you generated them or somebody else

zzz next thing

zzz are you actually calling send_stream_accept (i.ie STREAM ACCEPT) ? don't see it in the logs

zzz next thing

zzz sounds like you're testing with i2pd? you may wish to try with java i2p, it gives better error messages via SAM