zzz
-1 up with lots of good stuff, please test, have fun
dr|z3d
anything new, or anything new you're now working on that isn't up yet?
zzz
w.r.t. cannon, it's a mix of stuff you already have and some stuff you don't
dr|z3d
let's see what you gone done :)
dr|z3d
you been busy
zzz
my wip locally is down to about 40 files and 2k lines of diff
zzz
still need eyedeekay to look at more MRs
zzz
I did another pass on the old /configadvanced MR, changed lists to table
zzz
at your suggestion? can't remember
dr|z3d
yeah, blame me.
dr|z3d
you might want to snag the associated + javascript for the config table.
dr|z3d
"concertina 'r us"
zzz
doesn't seem like something that needs js, but I'll await eyedeekay's 2nd look
dr|z3d
I'd love to see you implement that without js.
zzz
comments are open on the MR ))
dr|z3d
*** chuckles ***
dr|z3d
take it, leave it. either way works for me :)
zzz
*** chuckles back, testing CTCP ***
dr|z3d
in brief, the js exposes one section at a time on toggle, largely to avoid overwhelming new users and keeping the vertical height of the document reasonable.
dr|z3d
by default, just the section headers are visible.
dr|z3d
zzz: can you explain briefly what you're optimizing in this patch please? (like everything jrobin, it's not entirely clear what's going on :)) git.idk.i2p/i2p-hackers/i2p.i2p/-/commit/6aa6dad5be502643690b5d10c7c109ce6192dbf9
zzz
sure
zzz
2 things
zzz
1) drawRules() and drawSpans() each passed thru the same data, and did a clip() whether they had data to write or not, so I combined them and fixed that
zzz
2) the little square legend box color code was drawn 3 times with 3 different colors on top of each other; that's pointless unless the colors above you have transparency
zzz
could do even better with some basic color math like Color c = combine(Color top, Color bottom)
dr|z3d
good stuff, thanks. I strip a lot of the crap out before rendering to svg in jfree, but that sounds like some useful crud removal.
dr|z3d
did you pass that back up the chain yet?
zzz
no, still awaiting 3.10 release
dr|z3d
ok, fair enough. my prediction that he'd be fairly punctual on the release was wrong. :|
zzz
idea: QR code crash reports: github.com/kdj0c/panic_report/issues/1 discussion.fedoraproject.org/t/f42-change-proposal-enable-drm-panic-system-wide/125542
dr|z3d
horrible idea :)
zzz
yeah he restarted whatever his clock is with some mongodb change
dr|z3d
kernel panics might warrant qr codes because that's the only way to save the error data, but we're not a kernel :)
zzz
yeah not useful unless we have a report submission service, and if we had that we'd just add a submit button on the error page
dr|z3d
no reason we can't add a submit report button and use a redacted version of the system info and logs.
dr|z3d
dunno if it's worth the effort, though. but that's your call.