@eyedeekay
&eche|on
&kytv
&zzz
+R4SAS
+RN
+StormyCloud
+T3s|4
+acetone
+dr|z3d
+hagen
+orignal
+postman
+weko
An0nm0n
Arch
Danny
DeltaOreo
DiCEy1904
FreefallHeavens
Irc2PGuest43975
Irc2PGuest48909
Irc2PGuest67564
Irc2PGuest91332
Onn4l7h
SoniEx2
T3s|4_
Teeed
anon2
b3t4f4c3__
bak83_
boonst
cumlord
dr4wd3
eyedeekay_bnc
goose2
goose2_
hk
itsjustme
j6
not_bob_afk
numberwang
onon_1
poriori_
profetikla
qend-irc2p
rapidash
shiver_
u5657
unwr
veiledwizard
w8rabbit
x74a6
zzz
ping eyedeekay
eyedeekay
pong zzz
zzz
eyedeekay, github 3 weeks behind
eyedeekay
Restarted the sync script, should be good in a moment
zzz
thanks
zzz
eyedeekay, re: MRs
zzz
what goes in for the release and when is up to you
zzz
but if you want any of the things on my list you need to pick up the review pace or we're going to run out of time
zzz
what I've posted so far is maybe a quarter of what I'm sitting on
eyedeekay
Ack I'll focus up on the existing ones today
zzz
and ditto for whatever you're sitting on, nothing from you so far
zzz
vacation's over, let's get to work :)
eche|off
vacation? no vacations available...
dr|z3d
last 3 MRs from zzz are probably the easiest the wave through, I'm running 2/3 without issue.
dr|z3d
also, don't forget snark, zzz, re iframe-resizer. that also benefits.
dr|z3d
with iframe-resizer deployed, you can ship snark with the add/create sections collapsed, as intended.
dr|z3d
it'll also benefit the ajax search, because that changes the height of the page when activated.
zzz
yeah eyedeekay if you have q's on any of them ask here, drz may have the answers
zzz
so the plan is a -3 tonight or tomorrow with whatever gets approved
zzz
and then we'll go around again with the next batch
dr|z3d
I don't think you're using the data-iframe-height attribute to set the child window height, zzz; I found that the most reliable method.
dr|z3d
*to set the container iframe height, sorry.
dr|z3d
also, re sidebar comments in your MR notes, unless I'm mistaken, I think we did away with the iframe container a long time ago.
zzz
it wasn't necessary for the 4 embeds, but it is necessary for susimail html emails, in a MR to come
dr|z3d
to collapse the snark sections by default, just toggle the default checkbox state.
eyedeekay
nack for now on advanced config splitting, dark theme is broke, I'll suggest some changes tonight
eyedeekay
That's probably all the review I'll reasonably get to today, got a couple other things on my docket still
zzz
agreed, I don't think that one is ready