@eyedeekay
&zzz
+R4SAS
+RN
+T3s|4
+dr|z3d
+hk
+orignal
+postman
+snex
Arch
BravoOreo
Dann
FreefallHeavens_
Irc2PGuest11045
Irc2PGuest3921
Irc2PGuest59134
Irc2PGuest60478
Irc2PGuest62721
Leopold_
Onn4l7h
Onn4|7h
Sleepy_
Soni
T3s|4_
Teeed_
acetone_
aeiou_
aisle
ardu
b3t4f4c3___
b4dab00m
bak83_
bpb
cumlord
dickless
dr4wd3
enoxa
eyedeekay_bnc
hagen_
not_bob_afk
plap
poriori
profetikla
qend-irc2p
radakayot_
rapidash
shiver_
solidx66_
u5657
uop23ip
w8rabbit
weko_
wodencafe2
x74a6h
dr|z3d
eyedeekay: in your proposed merged, you've changed floodfillNetDB to mainNetDB in RouterContext.java .. you'll need to replace all calls to floodfillNetDB -> mainNetDB to make that work.
dr|z3d
I was seduced by the "fixes all downstream issues" promise, but sadly I still have no geoip lookups.
dr|z3d
eyedeekay: you've marked merge #105 as ready despite CI failing because of the issue I mentioned earlier.
dr|z3d
>> eyedeekay: in your proposed merged, you've changed floodfillNetDB to mainNetDB in RouterContext.java .. you'll need to replace all calls to floodfillNetDB -> mainNetDB to make that work.
dr|z3d
if you're not ready to swapout floodfillNetDB for mainNetDB, then you'll need to revert in RouterContext.java
obscuratus
dr|z3d: I'm confused. I'm running that already in my testing network. I don't think it would even build if all the floofillNetDB references hadn't been removed.
obscuratus
If I run through my code with that branch checked out, I dont find any calls to floodfillNetDB.
eyedeekay
That's not why CI is failing
dr|z3d
Ok, my bad. I must have missed the changeover. I see it's correct in master in SegmentedNDF: public abstract FloodfillNetworkDatabaseFacade mainNetDB();
dr|z3d
so I can just search and replace floodfillNetDB with mainNetDB and then I've got parity with upstream regarding that naming scheme.
dr|z3d
I applied your proposed API fixes, still no flags in the console, alas.
eyedeekay
Sorry. I've still got a boatload of refactoring to do and fixes to devise but if I can help after I'll try
dr|z3d
No worries, wasn't asking for help, just reporting back.
R4SAS
guys, when are you planning to release?