+dr|z3d
+orignal
+postman
+qend-irc2p
+sourceress
Arch
Birdy
Danny
Irc2PGuest23180
Irc2PGuest35290
Irc2PGuest36302
Irc2PGuest49364
Irc2PGuest49480
Irc2PGuest51117
Irc2PGuest6564
Irc2PGuest67278
Irc2PGuest71245
Irc2PGuest90409
MatrixBot
Onn4l7h
Over
Sleepy
StormyCloud
Teeed
Yotsu
_bob_
aargh3
ac9f
acetone_
ahiru
anontor2
b3t4f4c3__
cims_
dr4wd3_
duanin2
eche|off
eyedeekay_
f00b4r
ghirolt
hababam_
leopold
marek
n2
nilbog
noidea
not_bob_afk2
nyaa2pguy
o3d3_
poriori
profetikla
r00tobo
rapidash
solidx66
stormycloud[m]
test7363673
uop23ip
urist_
user_
w8rabbit
zelgomer
zzz
zzz
ding ding ding, congrats :) gitlab.com/i2pplus/I2P.Plus/-/commit/5da3fa7a4c3d3829e406badaaae12acee8efbf30
dr|z3d
Is that your Hector Salamanca impression? :)
zzz
lol
RN
Σ:Đ
zzz
I told you last week, find your line in the loop and delete it, but you chose the harder road
zzz
want to know why it was so hard?
dr|z3d
enlighten me..
zzz
so presumably you are deciding to do something different if the router you're looking for is "uninteresting", right?
dr|z3d
yeah, Refresh Routers Job is where I'm determining if the routers are interesting enough to do a lookup on. Get router, if it's interesting, refresh as required, if not, don't bother, we'll get it again if it's needed.
zzz
or in lookupBeforeDropping()
dr|z3d
yeah, I think I just drop there too. but maybe I've omitted an isUs check somewhere so we don't go nuts on our own RI.
zzz
pick your spots, don't spray mods everywhere, it all got too glitchy
zzz
also recommend testing low bw and/or firewalled more often
dr|z3d
good advice.
dr|z3d
because !isHidden, obviously firewalled and hidden mode don't always trigger the same bug.
zzz
I mean, the bad line was in there for a year and a half, stuff can come back to bite you a long time later
zzz
but figure out why you're deleting your own RI, thats not good
zzz
and could be causing other hard to reproduce problems
dr|z3d
that's an easy one. not checking for isUS.
dr|z3d
fine in RefreshRoutersJob
dr|z3d
if (h.equals(getContext().routerHash()))
dr|z3d
continue;
dr|z3d
or doing a lookup on our own key. think I've got it.
zzz
tl;dr hack less, test more :)
dr|z3d
:) lesson learnt, thanks for the input.
zzz
np
dr|z3d
how is zzz's outlook now? clearing, sunny, or storm clouds ahead? :)
zzz
whatever it is, the above convo doesn't change it
dr|z3d
of course. just hoping you find yourself in a better frame of mind than last week.
zzz
thx, catching up, still more to do