&zzz
+FreefallHeavens
+R4SAS
+RN_
+Romster
+StormyCloud
+cims
+eche|off
+hagen
+mareki2p
+nilbog
+nyaa2pguy
+orignal
+postman
+qend-irc2p
+rednode
+snex
+synergy3582
+wodencafe
Arch
Danny
FatherTime
Holmes
Irc2PGuest17692
Irc2PGuest28384
Irc2PGuest32652
Irc2PGuest37450
OfficialCIA
Onn4l7h
Onn4|7h
Over
Sleepy
U1F642
Zapek
aargh4
ac9f
acetone_
ahiru
ananas_
anontor
calamares
dr4wd3
duanin2
eyedeekay_bnc
ice_juice
leopold
mahlay
makoto
marek
n2_
not_bob_afk2
poriori
profetikla
r00tobo
rapidash
test3847473
uop23ip
x74a6
zelgomer
zzz
ding ding ding, congrats :) gitlab.com/i2pplus/I2P.Plus/-/commit/5da3fa7a4c3d3829e406badaaae12acee8efbf30
dr|z3d
Is that your Hector Salamanca impression? :)
zzz
lol
RN
Σ:Đ
zzz
I told you last week, find your line in the loop and delete it, but you chose the harder road
zzz
want to know why it was so hard?
dr|z3d
enlighten me..
zzz
so presumably you are deciding to do something different if the router you're looking for is "uninteresting", right?
dr|z3d
yeah, Refresh Routers Job is where I'm determining if the routers are interesting enough to do a lookup on. Get router, if it's interesting, refresh as required, if not, don't bother, we'll get it again if it's needed.
zzz
or in lookupBeforeDropping()
dr|z3d
yeah, I think I just drop there too. but maybe I've omitted an isUs check somewhere so we don't go nuts on our own RI.
zzz
pick your spots, don't spray mods everywhere, it all got too glitchy
zzz
also recommend testing low bw and/or firewalled more often
dr|z3d
good advice.
dr|z3d
because !isHidden, obviously firewalled and hidden mode don't always trigger the same bug.
zzz
I mean, the bad line was in there for a year and a half, stuff can come back to bite you a long time later
zzz
but figure out why you're deleting your own RI, thats not good
zzz
and could be causing other hard to reproduce problems
dr|z3d
that's an easy one. not checking for isUS.
dr|z3d
fine in RefreshRoutersJob
dr|z3d
if (h.equals(getContext().routerHash()))
dr|z3d
continue;
dr|z3d
or doing a lookup on our own key. think I've got it.
zzz
tl;dr hack less, test more :)
dr|z3d
:) lesson learnt, thanks for the input.
zzz
np
dr|z3d
how is zzz's outlook now? clearing, sunny, or storm clouds ahead? :)
zzz
whatever it is, the above convo doesn't change it
dr|z3d
of course. just hoping you find yourself in a better frame of mind than last week.
zzz
thx, catching up, still more to do