@eyedeekay
+R4SAS
+RN
+RN_
+T3s|4
+Xeha
+not_bob
FreeRider
Irc2PGuest75862
Onn4l7h
Onn4|7h
T3s|4_
aargh3
acetone_
anon4
cancername
eyedeekay_bnc
orignal_
profetikla
shiver_1
u5657
weko_
x74a6
zzz
dr|z3d, you're on your own, you could just change it to WARN, I probably will eventually
zzz
orignal, I got a session created from i2pd with a termination in it
zzz
8/26 01:37:17.047 WARN [ handler 1/1] sport.udp.EstablishmentManager: Corrupt Session Created on: OES2 RQ15m4 51.83.230.80:61441
zzz
Caused by: java.io.IOException: Illegal block in handshake: 6
zzz
the spec allows it but I didn't handle it very well
zzz
in what cases do you do that?
dr|z3d
ok, zzz, thanks.
orignal
zzz, clock skew ofc
orignal
what's wrong with it?
orignal
and there are few more resons
zzz
nothing wrong, I just don't handle it very well, haven't seen it before
orignal
yes, I do it in the code
orignal
in case of error I add termination block
orignal
but what you do it case of clock skew?
zzz
clock skew where? session request?
orignal
yes it session request
zzz
same as for skew in token request: send retry with zero token and terminatino block
orignal
so, I send retry instead session created?
zzz
that's my recommendation, yes, it's a lot more efficient
orignal
can you add it to the specs?
orignal
because I thought we must always reply with SessionCreated to SessionRequest
zzz
ok will try to clarify in the specs
orignal
will change it
zzz
of course replying with retry is normal if the token is bad
dr|z3d
zzz: very minor logging correction, though you may disagree (or just laugh).. in PeerState you're receiving acks _by_ when in this context "from" is probably a better fit.
zzz
line #?
dr|z3d
various, grep for Received (partial) ACK.. 2099,1982, 1987, 2109..
zzz
ok
dr|z3d
"from" or "sent by" would both work.
zzz
he;s the one that acked it so it's acked 'by' him
zzz
probably jrandom logging
dr|z3d
sure, it's acked by the sender, but you're recieving an ack _from_ him, the by is implicit.
dr|z3d
I'm not a fan on receiving _on_ either, for acks, sending to, receiving from.
dr|z3d
yeah, receiving/received on, sent on.. just reads funny.
orignal
fixed. send retry instead session created
zzz
thanks. working on the spec now