IRCaBot 2.1.0
GPLv3 © acetone, 2021-2022
#i2p-dev
/2022/05/23
zzz eche|on, eche|off what's your schedule look like today for switch flipping?
eche|off mostly later, 3h+
zzz ok, you can expect it will be ready around then, thanks
eyedeekay Standing by whenever it's ready here as well
zzz eyedeekay, I must ask again that you get your editor under control or find a new one
zzz it's now more than just pointless changes and review time, there's cases where the result is reduced readability
eyedeekay OK, I'll switch to something that doesn't try to format things for i2p.*
zzz at the least you can't just accept the result, you have to be willing to restore the damage before checkin
zzz see e.g. SAMBridge.java line 240 where you thrashed a commented-out method
zzz if you were reviewing the full diff, including whitespace changes, before checkin, and cared to repair things, that wouldn't happen
eyedeekay I see, I'll change my procedures, switch back to a regular text editor and look closer at whitespace and comment changes
zzz great, thanks. whitespace changes aren't the end of the world but they can't make readability worse or violate our coding standards
zzz anybody find anything in the code review?
eyedeekay Not in the code review, ton of small fixes in i2p.firefox and a few in i2p.android.base in the last week based on testing though
zzz source tagged and pushed
zzz newsxml metadata updated and pushed
zzz torrent live
zzz checksums added to blog post
zzz eyedeekay, eche|on all clear to flippa da switches afaik
eyedeekay Cool, I'll have mine flipped momentarily
eyedeekay eche|on want me to update yours too?
eche|on just did myself
zzz torrent starting to kick off
dr|z3d new and improved i2phides.me just in time for the latest release.
mesh dr|z3d: that is your inproxy?
dr|z3d it's operated by mark22k
dr|z3d I just helped with the revamp.
mesh dr|z3d: hmm interesting
mesh not a fan of the pseudo-sub domain approach but it looks nice
dr|z3d if it brings more people onto the network, it's a win. obviously less interesting for people with i2p already installed.
mesh dr|z3d: no I just just mean the way it takes an i2p address and then turns that into '${i2p.address}.b32.i2phides.me
ReturningNovice ♫ ♪ Our inproxy is better than yours, better than yours... ♪ ♫
dr|z3d mesh: you have a better idea?
dr|z3d one that will allow you to transparently search and browse any .i2p links on any of the pages? :)
ReturningNovice must respect robots.txt
mesh dr|z3d: probably something like i2phides.me/${i2p.address}
dr|z3d that would be problematic, mesh, for sites with absolute links.
mesh reg.i2phides.me loads very quickly. All my services don't load at all hehe.
mesh dr|z3d: I mean you can relativize two absolute urls against each other. it's not a big difference either way, but that kind of domain impersonation (1) makes good SS for i2phidesL impossible (2) is very misleading imo about what's actually happening. the site is a proxy after all and is definitely not an authority from the http perspective
dr|z3d All I can say mesh is "feel free to run your own service" :)
mesh well it's just some constructive criticism, it's not the end of the world
mesh also I think i2phides.me might be failing when it doesn't find an favicon.ico?
mesh ironically the stuff i2phides.me does -- creating a fake sub-domain, using the proxy target's favicon.ico as its own, using wildcard SSL to make users think they're secure -- in some circles this is described as a Domain Impersonation Attack or Domain Spoofing. hehe it's all a matter of perspective
mesh still, the more inproxies the better. the lack of inproxies is a big problem imho
ReturningNovice inproxies are only good to interest new users of I2P. They do not help I2P beyond awareness and are in no way a safe way for people to view the content they may see through said inproxy.