#i2p-dev (irc2p) | dev build 2.5.0-3 | Network reliability is degraded, please be patient as we work on mitigations

obscuratus I've run into a few errors in my logs on my testing network using 1.7.0-11 (sorry if these are out of date, I'm in the process of upgrading to -13)

obscuratus paste.idk.i2p/t/3udh4n

dr|z3d obscuratus: git.idk.i2p/i2p-hackers/i2p.i2p/-/commit/9d49dc7af72d3d2462452f6c16e6eaae98c85fc9

dr|z3d that covers one of the errors

dr|z3d eyedeekay: you want an overflow: auto; on your code {} rule.

dr|z3d same obscuratus paste without truncation: cake.i2p/view/Qwc5pz1fSO_nKMYgNrHgJI28jHIWEa0y4uXULmASW_dwnpXc8Ft8/Qwc5pz1fSO.txt

obscuratus dr|z3d: OK, thanks. I'll wait till I update before noting any other errors.

eyedeekay dr|zed thanks

dr|z3d sure thing, eyedeekay

eyedeekay Well actually part of me would like a clearer idea of which thing because I am kind of wondering which part I need to work on, I was just going to take it as a clue to have a look at <code> blocks before and after

eyedeekay I'm not just going to insert it everywhere blindly I was going to have a look at what it looks and what it changes where, I mean technically you wrote most of the CSS for my web site

eyedeekay Strictly speaking I'm not sure to which CSS file you are referring

eyedeekay But I'm guessing dark|light/console.css to begin with

dr|z3d eyedeekay: your pastebin.

dr|z3d sorry, I thought the context indicated what I was referring to.

dr|z3d because you've got 100vh on the <code> that's displaying the paste, it truncates the bottom of the text for longer pastes. add an overflow: auto to code {} and it's fixed.

mesh dr|z3d: where is the code for i2p's version of jetty?

dr|z3d apps/jetty for the mods.

dr|z3d mostly it's using select binaries.

mesh I find surprisingly little code in github.com/i2p/i2p.i2p/tree/master/apps/jetty/java/src/net/i2p/jetty.

dr|z3d try looking in your workspace, everything you're looking for is there.

dr|z3d and as I said, mostly it's using upstream binaries.

mesh dr|z3d: so the embedded Jetty relies on i2ptunnel right?

mesh that's what the "Webserver" tunnel is in, Tunnel Manager

dr|z3d it's integrated with i2ptunnel, yes.

mesh alright, I thought so. I wonder if somebody has tried integrating Jetty's Connector framerwork directly with I2P Sockets

mesh dr|z3d: do you know when the I2P HTTP Proxy Configuration there's a "Local Destination"

eyedeekay Thanks dr|zed it was probably obvious but I've spread myself a little here, hard to keep track

mesh where does that come from? Is it stored on disk somewhere? Does it change with every router restart?

eyedeekay mesh depends on the config, some do, some don't

eyedeekay depends on what you want to do, if you want to auth dests, don't change dests, obvious stuff like that

mesh eyedeekay: hey

eyedeekay Anything I can help you with mesh? dr|zed definitely knows more about the ins-and-outs of jetty than me, but I can probably help with i2ptunnel questions

eyedeekay It is stored on the disk, it'll be a `.dat` file, for the jetty site usually `eepsite/eepPriv.dat`

mesh eyedeekay: I was curious about the I2P HTTP Proxy and where it stores its destination keys.

dr|z3d keys are stored in .i2p/ usually unless you specify somewhere else, or are using a plugin with its own dest.

dr|z3d if you're creating a new server, it's always a good idea to specify a descrptive keyname before you save it, rather than relying on the default name.

eyedeekay Just to add, IIRC the HTTP proxy sets "New Keys on Reopen" to true so the keys aren't actually "stored" for longer than they're in use

dr|z3d really the user should be forced to supply their own.

mesh I see a ${CONFIG_DIR}/i2ptunnel.config.d but it contains no keys

dr|z3d ~/.i2p/

dr|z3d *.dat files.

mesh eyedeekay: oh I see. So the proxy is really not meant to have a long-lived destination keys.

eyedeekay More that it is considered a sort of "Sane default"

dr|z3d client services generally are ephemeral unless configured otherwise.

eyedeekay If you need one with a constant destination type, my advice would be to set up a second one and configure it otherwise

dr|z3d client service dests, that is.

mesh eyedeekay: what's the best place to start looking at the code behind the proxy? github.com/i2p/i2p.i2p/blob/master/apps/i2ptunnel/java/src/net/i2p/i2ptunnel/I2PTunnelHTTPClientBase.java ?

eyedeekay That's probably an OK place to get started, but I2PTunnelHTTPClient.java may be a more interesting choice

mesh eyedeekay: yes that makes sense

dr|z3d 'git grep outproxy' will give you a good hint.

mesh eyedeekay: ok thankyou

mesh does git actually have a grep command built in like that?

dr|z3d Blinded message

mesh it does git-scm.com/book/en/v2/Git-Tools-Searching

mesh learn something new every day. git has its own version of grep built in

eyedeekay TBF it might be piping stuff through grep, like how it pipes stuff through pagers automatically sometimes too

mesh eyedeekay: one would hope so

dr|z3d much faster than OS grep, it queries the db.

mesh seems google is liking outproxies less and less

zzz eyedeekay, can you get rid of the cloudflare css and js? not great for a site on our home page

zzz derp

zzz looks like a dumb jrandom bug from 2005

zzz dr|z3d, can you try this?

zzz diff --git a/core/java/src/net/i2p/data/i2cp/MessagePayloadMessage.java b/core/java/src/net/i2p/data/i2cp/MessagePayloadMessage.java

zzz index a70188b74..2d04fa693 100644

zzz --- a/core/java/src/net/i2p/data/i2cp/MessagePayloadMessage.java

zzz +++ b/core/java/src/net/i2p/data/i2cp/MessagePayloadMessage.java

zzz @@ -125,7 +125,7 @@ public class MessagePayloadMessage extends I2CPMessageImpl {

zzz */

zzz @Override

zzz public synchronized void writeMessage(OutputStream out) throws I2CPMessageException, IOException {

zzz - if (_sessionId <= 0)

zzz + if (_sessionId < 0)

zzz throw new I2CPMessageException("Unable to write out the message, as the session ID has not been defined");

zzz if (_messageId < 0)

zzz throw new I2CPMessageException("Unable to write out the message, as the message ID has not been defined");

eyedeekay polistern do you mind if I pull your changes in polistern/i2psam back into i2p/i2psam?

mesh Do long-lived Destinations have an advantage in the floodfill, I wonder? Or does it not matter since all Destinations expire after 15 minutes?

dr|z3d ok, zzz, thanks, will patch and test.

eyedeekay zzz I should be able to find a way, one way or another

eyedeekay Oh that version of my pastebin wasn't supposed to come back up, that's supposed to be pointed at my other pastebin but I turned a machine back on and it started answering requests again

eyedeekay That's my bad, I switched pastebins because I was tired of patching the cloudflare back out every time I updated

eyedeekay Will be resolved shortly

eyedeekay Obscuratus, I mirrored your paste at the right pastebin: glue.idk.i2p/t3udh4n/view

eyedeekay filite going down, cowyo taking back over

eyedeekay All right cloudflare is gone and so is filite

eyedeekay In case anyone needs to get something out of the old one: filite.idk.i2p/?i2paddresshelper=XeeEcrjZBSZvLCLt32HWWojBguqcQNIfCcYnLhCSpV3LHMHvq-3nkdVw3DGoJYEQnLEpbhLEH~KwUXs42auWcbRedx895ciACwHpMBnchqCYvYeqKNOnMnlZkpSGJNNSRXAcUM48WLh7v6PscDCDKQFN8KVo9n6OBm0KKQjmaQjIN3unappXVvN90d0Q6tWjftn1mTtm2Is4sYYM3glXr47IXPjTha~XW6Ex5wNqtD7pR5rNN5g5Xcpww2teT~mo52Z1xFE5g7ZgK3rHRVnShmolLNwU2VT1ZGqI5X74Tq6DPu6itln3SYyF6db-X

eyedeekay ZmsHQSOkEUtHxiMkxqdhPptYZYNy1m0avxbBAecKBdGPeHZV2rIMdL3prPQvi433tXfMCJvg08Frox31aVKrSvsaHDF1f1TVs20gXeIt91xkjsOT6SLgRutFtwvtnSOu0QCk~0CgJ-iuC1tgG725Gz-N2kQ4-dK8bM~54qAmCmBQAEAAcAAA==

eyedeekay paste.idk.i2p and glue.idk.i2p are the same site again

obscuratus eyedeekay: Thanks.

eyedeekay no problem

mesh man I feel bad restarting my router

RN don't feel bad as long as you do "graceful"

RN ;)

mesh eyedeekay: btw have you ever tried to use the console in windows high contrast mode?

eyedeekay Cannot say that I have, certainly not since Windows 10

eyedeekay But I can put it on my list of things to try

mesh eyedeekay: you should try it some time

eyedeekay Can you give me any description of what is going on?

eyedeekay Sure will do

eyedeekay I'm actually remoted into my windows machine, I'll just do it now...

mesh eyedeekay: hehe, a lot of things are broken. no checkboxes, no icons on buttons

eyedeekay well crap, that isn't great...

eyedeekay Lots of text is not showing up

eyedeekay Wow

eyedeekay That's going to be a project

mesh eyedeekay: it's no big deal. there's probably very few people out there like me using windows high contrast mode. but I am curious from a web developer perspective what you think is going on

eyedeekay TBH I don't have much idea yet

mesh it's annoying because I suspect the problem is CSS but my brain refuses to understand CSS so I never make much progress

mesh (frankly it's part of the reason why I'm not a fan of webapps in general)

eyedeekay But the predictable bit is that it will take adjusting the CSS to fix it

mesh eyedeekay: I think what happens is windows+chrome|firefox apply some kind of super-duper css override when high contrast mode is enabled

eyedeekay I don't blame you, CSS is simple enough but it seems to get used in ways that ultimately make it pretty incomprehensible

mesh and this collides with the CSS of a webapp like the i2p router web console

eyedeekay I like webapps but only because I hate cross-compiling for different GUI frameworks

eyedeekay But this is definitely a drawback

mesh I wish there was a way to tell Windows "Don't apply high-contrast css super duper overrides to this webapp because it already has a dark theme"

mesh eyedeekay: my eyes are very sensitive to light so I really appreciate the dark theme of the console, but as you can see something goes terribly wrong with the os level visual aid

eyedeekay I might be able to unapply the OS-applied presumably-CSS in my browser extension as a temporary workaround, but the real solution is going to be in the console css

mesh eyedeekay: like I said, I wouldn't worry about it. I don't think there are that many people out there using high contrast mode. When I need to work with the console I just turn it off, use the console, and then turn it back on

mesh but I am curious as to why it's such a cluster. every time I poke at it the css stuff just befuddles me

eyedeekay I don't know, seems at least a little important, unless it's also who asked about Brave in the Reddit thread, I've had 2 visual-impairment help requests this month

mesh according to accessabilly.com/accessibility-issues-concerning-windows-high-contrast-mode literally <5% of users use high contrast mode

mesh it's one of those things where it sucks to be in the <5%. I understand developers focusing on the other 95%

mesh the real solution would be to have the ability to turn off hcm for certain sites

eyedeekay I suppose if you're trying to solve it as a Windows developer or a Firefox developer for instance, and to be fair, I don't know that such a property *doesn't* exist

eyedeekay But I don't have the ability to add that to Firefox or Windows so for us I think if it doesn't exist I have to fix the CSS

eyedeekay It's arguably not that different from supporting other languages except maybe a little easier, I mean less than 5% of people speak French but we still have a French translation

eyedeekay maybe this?

mesh well I would put it down on your todo list hehe. Like I said there's an obvious work around that is a bit easier than learning a new language. I can quickly turn off high contrast mode and turn it back on agian

eyedeekay gist.githubusercontent.com/kypflug/e892313f65d786a64558a297e380403a/raw/d5303f77f569b51a2e27a8ce07b19e25d7386372/forced-colors.css

eyedeekay Looks like that snippet is supposed to disable forced colors, I'm going to test it

mesh hmm so forced colors mode is what high contrast mode does

eyedeekay According to an article from Microsoft anyway

eyedeekay If it works then anything's better than that mess in the short term

mesh yeah that would be great

mesh perfectly fine disabling forced colors mode/high contrast and relying on the console's dark theme

eyedeekay That's definitely going to be the simplest and least obtrusive solution if I can make it work

eyedeekay support.mozilla.org/en-US/kb/disable-high-contrast-mode-firefox seems related