zzz
dr|z3d, looks nice
zzz
but why inline svgs?
dr|z3d
ah, you got it zzz, good stuff.
dr|z3d
inline svgs confer a couple of advantages
dr|z3d
firstly, there's no delay as they load from disk, so they're available as soon as the css has loaded.
dr|z3d
secondly, they're svgs, so they're resolution independent.
dr|z3d
and thirdly, being svgs, they gzip nicely.
zzz
1) and 3) are negligible
zzz
my problem is with inlining, it makes it almost unmaintainable by anybody but you
dr|z3d
sure, in terms of perf.
zzz
if we want svgs lets put them in resources/images
zzz
if they're no different than the png version then we don't even need to do that
dr|z3d
they're super easy to maintain, but sure.
dr|z3d
they're different. see the bit above about resolution independent. they're also in most cases smaller than the pngs they replace (before gzipping).
zzz
this is a tiny tiny plugin, lets not overoptimize
dr|z3d
sure, tiny tiny and the css file you'll note is smaller than the original it replaces, keeping with tiny tiny. plus you've got 2 themes for the price of one :)
zzz
I would just find it super unpleasant to change any image if I wanted to
dr|z3d
I can make that super not-unpleasant in a jiffy.
zzz
yes I like the result, just not the implementation
dr|z3d
I can provide the masters, but I still recommend keeping them inline. you can change and encode and replace the existing images as you see fit with that url.
dr|z3d
up to you, anyways. I'm not dead set on inline or external.
zzz
impressed with your css-foo but I think it's too much for us mortals
zzz
we already have a resources dir so yes would much rather stick them in there
zzz
thinking of the next guy
dr|z3d
haha
dr|z3d
I guess "thanks" :)
dr|z3d
here are the masters: skank.i2p/socks/socks_images.zip
dr|z3d
toast notifcations working for you?
zzz
very cool
dr|z3d
great. I envisioned something like that in the console where you're currently using the systray icon?
dr|z3d
(with eventsource driving the popups)
dr|z3d
if you want to use those images from disk, just swapout the variable inlines for url refs. eg --socks: url(images/socks.svg) or whatever. or you can leave the css as is and keep the master svgs around in the event you do want to mod the images. up to you. I'll leave it in your hands.
zzz
yup, thanks for the contribution
dr|z3d
you're welcome.. might as well make it look good if we're promoting its use, and gauging on that basis if it should be moved to the console.
dr|z3d
icing on cake, zzz: skank.i2p/socks/socksoutproxy.css and skank.i2p/socks/infohelp.svg (improved toast notifications, tick icon on save button).
dr|z3d
I've used the infohelp icon on the toast notifications, looks less sterile that way, and tweaked the icon so it doesn't look crap on the light theme.
zzz
ok but chill out until I merge the other stuff, can't keep up
dr|z3d
that's it, done deal. unless you're planning on adding more features, not much doing now. it's in a good place.
dr|z3d
the toast shadow and inset border wasn't the best on the light theme, so I fixed that and tweaked a couple of other details. I know what you're like, you release and then it's curtains for a year :)
dr|z3d
optional screen logging of requests going through the socks proxy could be handy, and a bandwidth graph, but that's for v 2.0
zzz
I added a conn count but havent figured out where to put it
dr|z3d
you could fade from the tick to connections / speed under the status column.
dr|z3d
ie tick is displayed until traffic passes through the proxy, then tick is replaced with stats.
dr|z3d
if there's more info to be added down the line, the status table could be used for that, and the registered with i2p / plugin version could be moved elsewhere, perhaps on a footer at the bottom.
dr|z3d
anyways, just throw it up somewhere and I'll have a look at it.
zzz
ok. couple days
dr|z3d
no rush. I can see you're busy spinning a few plates over there.
zzz
as usual
dr|z3d
keeps you off the streets :)